feat: refactor global params #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
totraev
requested review from
gbarkhatov,
jrwbabylonlab and
jeremy-babylonlabs
totraev
force-pushed
the
9-improve-the-global-param-data-flow
branch
3 times, most recently
from
5f6ec2d to
91de21c
Compare
jrwbabylonlab
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Nice work @totraev LGTM in general with some small comments and questions.
Don't worry too much about "nit" comments
totraev
force-pushed
the
9-improve-the-global-param-data-flow
branch
from
71eb09d to
c48ddb8
Compare
|
@totraev could u resolve the conflicts and let's merge this PR today |
totraev
force-pushed
the
9-improve-the-global-param-data-flow
branch
from
c48ddb8 to
021b20f
Compare
totraev
force-pushed
the
9-improve-the-global-param-data-flow
branch
from
021b20f to
4737aea
Compare
jeremy-babylonlabs
pushed a commit
that referenced
this pull request
Oct 15, 2024
* feat: refactor global params * fix: version info data for loading state * fix: small review issues * fix: review issues
jeremy-babylonlabs
added a commit
that referenced
this pull request
Oct 16, 2024
* use correct height for unbonding model (#196) * fix: improvement on using the correct height for unbonding model --------- Co-authored-by: wjrjerome <[email protected]> * feat: enable another wallet on mainnet (#200) * fix na inconsistent display (#205) * fix small points amount display (#206) * fix: skip ordinals for cactus (#208) * fix: skip ordinals for cactus --------- Co-authored-by: Filippos Malandrakis <[email protected]> * fix: mempool endpoints errors should provide better UX (#165) * fix: mempool endpoints errors should provide better UX * fix: remove delegation from local storage only when error status is 404 * fix: delegations tests (#170) * feat: move wallet provider logic in react context (#178) * feat: refactor global params (#182) * feat: refactor global params * fix: version info data for loading state * fix: small review issues * fix: review issues * feat: added new api hooks and global states (#197) * feat: added new api hooks and global states * fix: review issues * fix: add new eslint rule for booleans * fix: FAQ test * fix: review feedback * use correct height for unbonding model (#196) (#202) * use correct height for unbonding model (#196) * fix: improvement on using the correct height for unbonding model --------- Co-authored-by: wjrjerome <[email protected]> * fix format --------- Co-authored-by: wjrjerome <[email protected]> * linting error * resolve comments --------- Co-authored-by: wjrjerome <[email protected]> Co-authored-by: Crypto Minion <[email protected]> Co-authored-by: Filippos Malandrakis <[email protected]> Co-authored-by: David Totrashvili <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9