use correct height for unbonding model #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-babylonlabs
requested review from
totraev,
gbarkhatov and
jrwbabylonlab
gbarkhatov
approved these changes
Oct 2, 2024
jeremy-babylonlabs
force-pushed
the
fix-incorrect-fee-sat-display
branch
from
8271759 to
d748ab1
Compare
totraev
approved these changes
Oct 3, 2024
|
@jeremy-babylonlabs you can merge. I'll resolve conflicts on my end |
jeremy-babylonlabs
force-pushed
the
fix-incorrect-fee-sat-display
branch
from
d748ab1 to
f03625e
Compare
|
ok resolved |
| <UnbondWithdrawModal | ||
| unbondingTimeBlocks={globalParamsVersion.unbondingTime} | ||
| unbondingFeeSat={globalParamsVersion.unbondingFeeSat} | ||
| delegationHeight={selectedDelegationHeight} |
There was a problem hiding this comment.
@jeremy-babylonlabs you don't need selectedDelegationHeight state.
You can reuse what's been done for the handleUnbond(txID) where it use the ID to locate the delegation from delegationsAPI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a hotfix for the unbonding modal. It now displays the correct info according to the delegation height.