Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error pages #224

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Add error pages #224

merged 1 commit into from
Oct 15, 2024

Conversation

supertong
Copy link
Contributor

@supertong supertong commented Oct 12, 2024

This PR adds in error pages.

  • error.tsx - for uncaught errors happens in the page
  • global-error.tsx - for uncaught errors that happens in layers above page, for example Providers.
  • not-found.tsx - for 404 route not found

I didn't change the overall design to make sure the error page styles are consistent with the existing pages. The design from Figma seems to be the new UI design?

Also, I haven't added any actions to those two buttons as I need information on where they should redirect user to or which email should they send to.

I will also post a recording video here.
https://www.loom.com/share/b18ea0ec70a94ccfb77ca4db480f020c?sid=7a743d20-5684-4dc1-bc1f-5a54d2742061

@jrwbabylonlab
Copy link
Collaborator

Close #158

@supertong supertong merged commit d4c69c8 into dev Oct 15, 2024
1 check passed
@supertong supertong deleted the tong/error-pages branch October 15, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants