feature: Tomo dual wallet #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbarkhatov
force-pushed
the
feature/tomo-dual
branch
from
bbd7205 to
35b6c9e
Compare
gbarkhatov
force-pushed
the
feature/tomo-dual
branch
from
35b6c9e to
f5504c3
Compare
gbarkhatov
requested review from
jrwbabylonlab,
totraev and
jeremy-babylonlabs
totraev
reviewed
Oct 18, 2024
|
@gbarkhatov PR need rebase unfortunately. |
|
@jrwbabylonlab yep |
jrwbabylonlab
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Nice work @gbarkhatov
Approved with some comment that need to be resolved. nothing major from my end.
totraev
approved these changes
Oct 22, 2024
gbarkhatov
force-pushed
the
feature/tomo-dual
branch
from
464e213 to
33cc70a
Compare
|
@totraev @jrwbabylonlab @jeremy-babylonlabs all solved, rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces Tomo wallet connector
Functionality is the same for the most of the components, with some changes:
bech32Address,pubKey,signArbitraryandconnected+disconnectMy suggestion: after the reviews and the discussion from the web side, we can think about the future tickets related to the wallet.
I currently see:
Closes #183 and partly closes #213