Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(phase-2): delegation tabs #240

Merged
merged 2 commits into from
Oct 25, 2024
Merged

feat(phase-2): delegation tabs #240

merged 2 commits into from
Oct 25, 2024

Conversation

totraev
Copy link
Contributor

@totraev totraev commented Oct 22, 2024 •
edited
Loading

  • Added new GridTable component
  • Created static UI for Phase-2 Delegations
  • Implemented FP table on top of GridTable, but didn't replace existing one (cause new component doesn't have mobile version atm)
  • Split delegations into 2 tabs

Before

Screenshot 2024-10-24 at 18 37 11

After

Screenshot 2024-10-24 at 18 33 24

@totraev totraev linked an issue Oct 22, 2024 that may be closed by this pull request
Delegation tabs UI #221
Closed
@totraev totraev force-pushed the 221-delegation-tabs-ui branch from db20db2 to aa8d9c3 Compare October 23, 2024 09:18
@totraev totraev marked this pull request as draft October 23, 2024 09:55
@totraev totraev force-pushed the 221-delegation-tabs-ui branch 2 times, most recently from b1fe7d1 to 14b3d67 Compare October 23, 2024 11:01
@totraev totraev marked this pull request as ready for review October 24, 2024 13:45
jrwbabylonlab
jrwbabylonlab approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@jrwbabylonlab jrwbabylonlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@totraev totraev force-pushed the 221-delegation-tabs-ui branch from 14b3d67 to 5e25f5b Compare October 25, 2024 10:26
@totraev totraev merged commit e75c2d0 into dev Oct 25, 2024
1 check passed
@totraev totraev deleted the 221-delegation-tabs-ui branch October 25, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrwbabylonlab jrwbabylonlab jrwbabylonlab approved these changes

@gbarkhatov gbarkhatov gbarkhatov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delegation tabs UI
3 participants
@totraev @gbarkhatov @jrwbabylonlab