Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: terms acceptance #250

Merged
merged 3 commits into from
Oct 26, 2024
Merged

feat: terms acceptance #250

merged 3 commits into from
Oct 26, 2024

Conversation

jeremy-babylonlabs
Copy link
Contributor

@jeremy-babylonlabs jeremy-babylonlabs commented Oct 23, 2024 •
edited
Loading

connect terms-acceptance post endpoint
doesnt post again if termsAcceptedLocalStorage is true

@jeremy-babylonlabs jeremy-babylonlabs changed the title add terms acceptance feat: terms acceptance Oct 23, 2024
jrwbabylonlab
jrwbabylonlab reviewed Oct 24, 2024
View reviewed changes
src/app/page.tsx Outdated Show resolved Hide resolved
jrwbabylonlab
jrwbabylonlab reviewed Oct 24, 2024
View reviewed changes
src/app/page.tsx Outdated Show resolved Hide resolved
totraev
totraev approved these changes Oct 24, 2024
View reviewed changes
src/app/hooks/useAcceptTerms.ts Outdated Show resolved Hide resolved
src/app/page.tsx Outdated Show resolved Hide resolved
src/app/page.tsx Show resolved Hide resolved
src/app/api/postTerms.ts Outdated Show resolved Hide resolved
jrwbabylonlab
jrwbabylonlab reviewed Oct 25, 2024
View reviewed changes
src/app/page.tsx Outdated Show resolved Hide resolved
vitsalis
vitsalis reviewed Oct 25, 2024
View reviewed changes
Copy link
Member

@vitsalis vitsalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly comments related to naming. I think we are confusing the act of accepting the terms with the act of logging the acceptance. This introduces a confusing naming convention.

src/app/api/postTerms.ts Outdated Show resolved Hide resolved
src/app/components/Modals/ErrorModal.tsx Outdated Show resolved Hide resolved
src/app/api/postTerms.ts Outdated Show resolved Hide resolved
src/app/api/postTerms.ts Outdated Show resolved Hide resolved
src/app/api/postTerms.ts Outdated Show resolved Hide resolved
src/app/hooks/useAcceptTerms.ts Outdated Show resolved Hide resolved
src/app/page.tsx Outdated Show resolved Hide resolved
@jeremy-babylonlabs jeremy-babylonlabs merged commit 3dffa40 into main Oct 26, 2024
1 check passed
@jeremy-babylonlabs jeremy-babylonlabs deleted the terms-acceptance branch October 26, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrwbabylonlab jrwbabylonlab jrwbabylonlab left review comments

@vitsalis vitsalis vitsalis left review comments

@totraev totraev totraev approved these changes

@gbarkhatov gbarkhatov Awaiting requested review from gbarkhatov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeremy-babylonlabs @vitsalis @totraev @gbarkhatov @jrwbabylonlab