Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preselect fp #380

Merged
merged 3 commits into from
Nov 27, 2024
Merged

preselect fp #380

merged 3 commits into from
Nov 27, 2024

Conversation

jeremy-babylonlabs
Copy link
Contributor

@jeremy-babylonlabs jeremy-babylonlabs commented Nov 24, 2024

closes #376

Screenshot 2024-11-25 at 3 36 27 AM

@jrwbabylonlab
Copy link
Collaborator

@jeremy-babylonlabs build failure

@jeremy-babylonlabs jeremy-babylonlabs force-pushed the feat/376-preselect-fp branch 2 times, most recently from 2213c49 to 371478d Compare November 25, 2024 08:05
gbarkhatov
gbarkhatov previously approved these changes Nov 25, 2024
Copy link
Contributor

@gbarkhatov gbarkhatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

totraev
totraev previously approved these changes Nov 25, 2024
@jrwbabylonlab
Copy link
Collaborator

image

this change basically pre-populate the search box. let's wait for the requirement to be confirmed

jrwbabylonlab
jrwbabylonlab previously approved these changes Nov 26, 2024
@jrwbabylonlab jrwbabylonlab dismissed stale reviews from totraev, gbarkhatov, and themself via 9a534b7 November 27, 2024 09:10
@jrwbabylonlab jrwbabylonlab merged commit fc84d24 into v0.3.x Nov 27, 2024
1 check passed
@jrwbabylonlab jrwbabylonlab deleted the feat/376-preselect-fp branch November 27, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[phase-1] pre-select FP
4 participants