Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update delegation list #400

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Conversation

jeremy-babylonlabs
Copy link
Collaborator

@jeremy-babylonlabs jeremy-babylonlabs commented Nov 27, 2024

closes #394

Screenshot 2024-11-28 at 2 52 18 AM

some notes

  • getting finality provider moniker from the v1 finality provider endpoint
  • v2 design for inception is showing date and time, but backend is returning blocks. so i added the estimatedBlockDurationTillNow func, im not sure if this is the best approach since the estimated time varies alot @jrwbabylonlab
    or we can just display the start block for now

@jrwbabylonlab
Copy link
Collaborator

@jeremy-babylonlabs i think we will replace the v1 FP with v2 completely. so probably no need to keep the v1 FP logic anymore. u can just replace it with new endpoint, new implementation.

@jrwbabylonlab
Copy link
Collaborator

@jeremy-babylonlabs

  1. The FP list seems empty, couldn't we get the value from the FP list?
  2. No, the API should have the BBN timestamp in the response. You can use that value for the phase-2 delegation inception field

@jeremy-babylonlabs jeremy-babylonlabs force-pushed the 394-update-delegation-lists branch from d34b565 to 02c7f33 Compare November 28, 2024 09:45
@jeremy-babylonlabs jeremy-babylonlabs force-pushed the 394-update-delegation-lists branch from 6bc09a8 to c115f28 Compare November 29, 2024 05:13
@jeremy-babylonlabs jeremy-babylonlabs merged commit 2bc92eb into main Nov 29, 2024
1 check failed
@jeremy-babylonlabs jeremy-babylonlabs deleted the 394-update-delegation-lists branch November 29, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants