-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feature: bbn-wallet-connect native lib #409
Conversation
006acd8
to
928a429
Compare
|
@@ -27,6 +27,7 @@ | |||
"dependencies": { | |||
"@babylonlabs-io/babylon-proto-ts": "0.0.3-canary.3", | |||
"@babylonlabs-io/bbn-core-ui": "^0.2.0", | |||
"@babylonlabs-io/bbn-wallet-connect": "^0.0.18", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the tomo dependency be removed from this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jrwbabylonlab Tomo wallet connect is not currently implemented, it requires additional abstraction
@totraev Should Tomo wallet connect be a dependency and the part of the simple-staking
or bbn-wallet-connect
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm getting confused. we are going to use the bbn-wallet-connect. why tomo is still here?
@totraev according to the design the connection flow assumption in the notes are correct - Once clicked BTC should be "connected" with the address and all of that only within the modal, not within the app |
@gbarkhatov can be closed in favor of new PR #413 |
The purpose of this PR is to have a working connection with the switch to a native wallet connector via
@babylonlabs-io/bbn-wallet-connect
This PR is a combination of:
main
changesIssues could be solved across different repos:
Prioritized:
Ordinals <- Can be a part of different PR
Build
Wallets disconnection process
Connection can be a part of later PRs
Scroll locker is minor
Tomo wallet connector is big, should be a part of later PRs
Connection persistance we're not touching right now
Problems, in terms of priority:
Scroll Locker
is not working. All the connection modals allow user to scroll. This is not the case for a regular app modals. For example, Preview modal is locking the scroll https://i.imgur.com/fV7ugQr.pngOverall the connection works, I was able to stake using OKX + Keplr