shuffle fp list #439
Closed
shuffle fp list #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-babylonlabs
requested review from
0xDazzer,
gbarkhatov and
jrwbabylonlab
- Refactor fp state management to shuffle the list on fetch, this update make sure when refetch it doesn't re-shuffle the list
jeremy-babylonlabs
force-pushed
the
427-fp-sort-randomly
branch
from
1e75eeb to
5d992ff
Compare
| finalityProvidersRef.current = [...updatedProviders, ...newProviders]; | ||
| } | ||
| } | ||
| }, [initialProviders, isRefetchingFinalityProviders]); |
There was a problem hiding this comment.
this logic seems quite complex thanks to the auto-refresh.
I wonder if it will make life easier if we just turn off the auto-refresh completely.
The auto-refresh exist due to tvl ranking, but now that we no longer doing the tvl sort, it doesn't really make much difference if we don't update the tvl in realtime.
gbarkhatov
approved these changes
Dec 4, 2024
| handleSearch, | ||
| }; | ||
| }; | ||
|
|
||
| const shallowCompareFP = (objA: FinalityProvider, objB: FinalityProvider) => { |
There was a problem hiding this comment.
we can say fpA instead of objA as this is shallowCompareFP
|
Closing as no longer needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #427