Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix search param handling #499

Merged
merged 7 commits into from
Dec 13, 2024
Merged

fix search param handling #499

merged 7 commits into from
Dec 13, 2024

Conversation

jeremy-babylonlabs
Copy link
Contributor

@jeremy-babylonlabs jeremy-babylonlabs commented Dec 12, 2024 •
edited
Loading

Screenshot 2024-12-13 at 2 20 11 AM

@jeremy-babylonlabs jeremy-babylonlabs force-pushed the fix/fp-search-param-handle branch from 8e126d6 to bc80afe Compare December 12, 2024 12:15
@jeremy-babylonlabs jeremy-babylonlabs force-pushed the fix/fp-search-param-handle branch from 55aac83 to 0b19e5a Compare December 12, 2024 14:27
totraev
totraev requested changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@totraev totraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait a moment

totraev
totraev approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@totraev totraev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic of search field was over engineered. I'd suggest to reduce the usage of useEffect hook as much as possible. In this particular case it can be replaced by a computed value (useMemo)

@totraev
Copy link
Contributor

totraev commented Dec 13, 2024

You guys need test it on staging again

@jeremy-babylonlabs jeremy-babylonlabs force-pushed the fix/fp-search-param-handle branch from 2b0840e to 2f3a587 Compare December 13, 2024 08:16
@jeremy-babylonlabs jeremy-babylonlabs merged commit 7f24075 into v0.3.x Dec 13, 2024
2 checks passed
@jeremy-babylonlabs jeremy-babylonlabs deleted the fix/fp-search-param-handle branch December 13, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrwbabylonlab jrwbabylonlab jrwbabylonlab approved these changes

@totraev totraev totraev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeremy-babylonlabs @totraev @jrwbabylonlab @filippos47