Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: OneKey Classic 1S #500

Merged
merged 5 commits into from
Dec 16, 2024
Merged

feat: OneKey Classic 1S #500

merged 5 commits into from
Dec 16, 2024

Conversation

gbarkhatov
Copy link
Contributor

@gbarkhatov gbarkhatov commented Dec 12, 2024 •
edited
Loading

Addition of OneKey Classic (with firmware version and experimental flag) in

@jrwbabylonlab
Copy link
Collaborator

i had to say the modal is becoming very hard to read as we keep adding more stuff into it
image

Probably best to ping Dan for his opinion. for example, maybe add a show more for the paragraph that is too long

@jrwbabylonlab
Copy link
Collaborator

btw, only taproot is supported in the oneKey hardware wallet. do we want to highlight this?

@vitsalis
Copy link
Member

btw, only taproot is supported in the oneKey hardware wallet. do we want to highlight this?

Oops, yes my recommendation removed the highlight of taproot only.

The following are the only hardware wallets supporting Bitcoin Staking: (1) Keystone -- via QR code and (2) OneKey -- via the OneKey Chrome extension and the hardware devices (a) OneKey Pro and (b) OneKey Classic 1s (experimental, <code><strong>3.10.1</strong></code> firmware or higher) using <strong>Taproot only</strong>

Agree it's becoming unreadable

@jrwbabylonlab
Copy link
Collaborator

this PR is outdated, pending decision whether we still need it, as well as need to rebase from base branch

@gbarkhatov gbarkhatov merged commit fc71f61 into v0.3.x Dec 16, 2024
1 check passed
@gbarkhatov gbarkhatov deleted the feat/onekey-classic branch December 16, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitsalis vitsalis vitsalis left review comments

@jrwbabylonlab jrwbabylonlab jrwbabylonlab approved these changes

@totraev totraev totraev approved these changes

@jeremy-babylonlabs jeremy-babylonlabs Awaiting requested review from jeremy-babylonlabs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gbarkhatov @jrwbabylonlab @vitsalis @totraev