Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add phase 1 unbond button and hook up modal #503

Merged

Conversation

jeremy-babylonlabs
Copy link
Collaborator

@jeremy-babylonlabs jeremy-babylonlabs commented Dec 13, 2024

Screenshot 2024-12-13 at 8 07 47 PM

did some refactoring along the way to clean it up
button looks abit different from original design, will need to fix the core-ui for this. but this shouldn't block the merge

@jeremy-babylonlabs jeremy-babylonlabs requested review from jrwbabylonlab, 0xDazzer and gbarkhatov and removed request for jrwbabylonlab December 13, 2024 12:12
@jeremy-babylonlabs jeremy-babylonlabs force-pushed the feat/449-show-unbonding-option-for-phase-1-delegation branch from f52b39d to 7856d71 Compare December 13, 2024 12:14
Copy link
Contributor

@gbarkhatov gbarkhatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides @jrwbabylonlab comments and the implementation looks correct in terms of UI

@0xDazzer
Copy link
Contributor

0xDazzer commented Dec 17, 2024

will need to fix the core-ui for this

@jeremy-babylonlabs lets discuss this before you start. Feel free to ping me when you have time

@jeremy-babylonlabs jeremy-babylonlabs force-pushed the feat/449-show-unbonding-option-for-phase-1-delegation branch from f9bac82 to 21f9a99 Compare December 17, 2024 20:25
@jeremy-babylonlabs jeremy-babylonlabs merged commit e150321 into main Dec 17, 2024
1 check passed
@jeremy-babylonlabs jeremy-babylonlabs deleted the feat/449-show-unbonding-option-for-phase-1-delegation branch December 17, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants