Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fallback to mempool get tip height if wallet stop working #508

Closed
wants to merge 1 commit into from
Closed

fix: fallback to mempool get tip height if wallet stop working #508

wants to merge 1 commit into from

Conversation

jrwbabylonlab
Copy link
Collaborator

No description provided.

@jrwbabylonlab jrwbabylonlab force-pushed the fallback-mempool-getHeight branch from 444e959 to 3b925e3 Compare December 15, 2024 08:42
@jrwbabylonlab
Copy link
Collaborator Author

On hold

@jrwbabylonlab
Copy link
Collaborator Author

Removed the PR. The issue is not returning 0. but wrong height was returned.
if we want to do a hot fix, we need to remove the dependency on the wallet get tip height and go with mempool directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@totraev totraev totraev approved these changes

@vitsalis vitsalis Awaiting requested review from vitsalis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrwbabylonlab @totraev