fix: exclude the oneKey from injectable wallet #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrwbabylonlab
requested review from
vitsalis,
gbarkhatov and
jeremy-babylonlabs
gbarkhatov
approved these changes
Aug 16, 2024
jeremy-babylonlabs
approved these changes
Aug 16, 2024
|
We should add an issue to keep track / revisit later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OneKey still haven't release their changes until now (suppose to be monday this week or even earlier)
Also realise some users may already have oneKey installed and never upgrade it, then the issue will still exist for those users.
I decide to go with this super hacky and simple approach because don't want to mess up with the injectable logic in the last minute of launch.
also tested on mobile