feature: Terms and Privacy modals #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbarkhatov
requested review from
vitsalis,
jrwbabylonlab and
jeremy-babylonlabs
jrwbabylonlab
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
LGTM in general with some minor comment on the text and recommendation that don't need to be addressed in this PR:
- The privacy modal is a bit unnecessary as it's the same as the terms modal. We can have a generic modal component that would fit both use-cases. (We need to host the documents in different url anyway in the next cap, so it's ok to leave it as it is)
- Is this really fits into
src/app/providers.tsxas a global context? IMO, the global stats from the useContext is a good place for core things such as the btc height and global params where a lot of components will be using. But we don't need to use the terms and privacy in different components, right? Let's move it out in laterdevbranch when we do the improvement. The terms and private has big text paragraphs, it may have performance impact on the dApp when loaded at the context. Although i tested it seems to be ok today.
Understand right now is not the best time for doing this. I will track this in our github issues
fyi, i bumped the package json version (Ouch! Didn't see another PR with the version bump 😮💨 )
gbarkhatov
commented
Aug 21, 2024
gbarkhatov
force-pushed
the
feature/terms-privacy-container
branch
from
604746f to
23924dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vitsalis @jeremy-babylonlabs @jrwbabylonlab please carefully check the text content
@jeremy-babylonlabs please additionally check out any stylings inconsistencies