fix(swe): wait for stacking tx to be k-deep #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazar955
commented
Nov 19, 2024
|
|
||
| // make sure we didn't submit any "invalid" incl proof | ||
| require.Eventually(t, func() bool { | ||
| return promtestutil.ToFloat64(stakingTrackerMetrics.FailedReportedActivateDelegations) == 0 |
There was a problem hiding this comment.
New code is blocking until we are K-deep, we expect no errors here
KonradStaniec
approved these changes
Nov 20, 2024
Lazar955
added a commit
that referenced
this pull request
Nov 20, 2024
Wait for the stacking transaction to be k-deep before submitting the inclusion proof
Lazar955
added a commit
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for the stacking transaction to be k-deep before submitting the inclusion proof