feat(monitor): bootstrap monitor from db #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/monitor-stored-bootstrap
RafilxTenfen
reviewed
Sep 9, 2024
monitor/monitor.go
Outdated
Comment on lines
137
to
146
| // get the height from db if it exists otherwise use the baseHeight provided from genesis | ||
| var startHeight uint64 | ||
| dbHeight, exists, err := m.store.LatestHeight() | ||
| if err != nil { | ||
| panic(fmt.Errorf("error getting latest height from db %w", err)) | ||
| } else if !exists { | ||
| startHeight = baseHeight | ||
| } else { | ||
| startHeight = dbHeight | ||
| } |
There was a problem hiding this comment.
suggestion to extract this into a func
RafilxTenfen
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Have you considered using the KVStore to be similar to what is being used in the Babylon code?
besides that, only a few suggestions that are no impediments to merge! 🎉
Nice suggestion, but I've seen that we use this in our btc-staker and indexer, Konrad suggested to go with it |
gitferry
approved these changes
Sep 10, 2024
| @@ -34,6 +34,7 @@ var ( | |||
| eventuallyWaitTimeOut = 40 * time.Second | |||
| eventuallyPollTime = 1 * time.Second | |||
| regtestParams = &chaincfg.RegressionNetParams | |||
| defaultEpochInterval = uint(400) //nolint:unused | |||
There was a problem hiding this comment.
Suggested change
| defaultEpochInterval = uint(400) //nolint:unused | |
| defaultEpochInterval = uint(400) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the monitor to start from the last processed confirmed header, we also save the epoch
References issue.