feat(submitter): stateful submitter #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazar955
commented
Sep 13, 2024
| // that has already been processed. | ||
| // Returns true if the first transactions are in the mempool (no resubmission needed), | ||
| // and false if any transaction was re-sent from the store. | ||
| func maybeResendFromStore( |
There was a problem hiding this comment.
Meat and potato of the PR
Lazar955
commented
Sep 13, 2024
| "testing" | ||
| ) | ||
|
|
||
| func Test_maybeResendFromStore(t *testing.T) { |
There was a problem hiding this comment.
e2e test for this would be quite hard to implement with timings, opt for a unit
gitferry
approved these changes
Sep 16, 2024
Comment on lines
+104
to
+116
| hasBeenProcessed, err := maybeResendFromStore( | ||
| ckptEpoch, | ||
| rl.store.LatestCheckpoint, | ||
| rl.GetRawTransaction, | ||
| rl.sendTxToBTC, | ||
| ) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if hasBeenProcessed { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
seems this chunk of code is irrelevant to whether we should send a complete ckpt or only the second half. Can we move it out to avoid duplicate code?
Comment on lines
+127
to
+130
| err = storeCkptFunc(submittedCkpt.Tx1.Tx, submittedCkpt.Tx2.Tx, submittedCkpt.Epoch) | ||
| if err != nil { | ||
| return err | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of a restart, we want to avoid wasting fees if we have already submitted transactions for a certain epoch.
Basic idea:
A crash occurs after sending both checkpoint transactions for epoch
nto the BTC and recording them in the database. Upon restarting, we find that epochnis still marked as sealed.Before resending the transactions we first check our database and confirm that the transactions for this epoch have already been sent. Since the transactions were previously sent, the next step is to verify their status on our Bitcoin node.
If the Bitcoin node is aware of the transactions and they are present in the mempool, no further action is needed.
However, if the node does not recognize the transactions, this indicates they were lost, and we must resend them to the network.
References