chore(e2e): removing btcd #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-cleanup of test manager
There was a problem hiding this comment.
few small comments, but in general looks good
Few additional things:
- in our makefile we can now delete
btcdandbtcwalletfromtest-e2ecommand: https://github.com/babylonlabs-io/vigilante/blob/dev/Makefile#L55 - in tools.go we can delete the btcd and btcwallet import - https://github.com/babylonlabs-io/vigilante/blob/dev/tools/tools.go#L8
- in our second go.mod we can also delete those - https://github.com/babylonlabs-io/vigilante/blob/dev/tools/go.mod#L9
| // Config setting necessary to connect btcwallet daemon | ||
| defaultConfig.BTC.BtcBackend = "btcd" | ||
| defaultConfig.BTC.BtcBackend = types.Bitcoind | ||
| defaultConfig.BTC.WalletEndpoint = "127.0.0.1:18554" |
There was a problem hiding this comment.
One follow up task we can have is to remove any references to btcd backend, for example:
.WalletEndpointconfig option makes sense only in case of btcd/btcdwallet combo, in case of bitcoind there will be always one endpoint for bitcoind note/wallet.BTC.BtcBackendoptions now makes little sense as we intend to support one backed ie bitcoind
There was a problem hiding this comment.
Makes sense to be a separate PR, as the config is used in other places also
e2etest/slasher_e2e_test.go
Outdated
|
|
||
| bsTracker := bst.NewBTCSTakingTracker( | ||
| tm.BTCClient, | ||
| backend, | ||
| tm.BabylonClient, | ||
| &bstCfg, | ||
| &commonCfg, | ||
| logger, | ||
| metrics, | ||
| rootLogger, |
There was a problem hiding this comment.
maybe we don't need logs for tests
Suggested change
| rootLogger, | |
| zap.NewNop(), |
| // mine a block that includes slashing tx | ||
| tm.MineBlockWithTxs(t, tm.RetrieveTransactionFromMempool(t, []*chainhash.Hash{unbondingSlashingMsgTxHash})) | ||
| require.Eventually(t, func() bool { |
There was a problem hiding this comment.
Would be nice to wrap up these eventually check into a function inside the test manager, but is only a suggestion
RafilxTenfen
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes btcd for running e2e tests and uses bitcoind. Reference issue