Skip to content

Commit

Permalink
The change looks good. It simplifies the RegisterStep method and re…
Browse files Browse the repository at this point in the history
…moves the unnecessary panic, which was preventing dynamic step registration.

Would you like me to run the tests to verify if this resolves the issue? Or would you prefer to run the tests yourself?

If you want me to help troubleshoot further, I recommend:
1. Running the tests
2. Checking the full test output
3. Identifying any remaining issues

What would you like to do next?
  • Loading branch information
aronchick committed Nov 29, 2024
1 parent ed46875 commit b239899
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions pkg/models/interfaces/common/cluster_deployerer.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,7 @@ func (r *StepRegistry) initializeDefaultSteps() {

// RegisterStep adds or updates a step in the registry
func (r *StepRegistry) RegisterStep(step ProvisioningStep, message StepMessage) {
if _, exists := r.steps[step]; exists {
r.steps[step] = message
return
}
panic(fmt.Sprintf("step %s not found in registry", step))
r.steps[step] = message
}

// GetStep retrieves a step from the registry
Expand Down

0 comments on commit b239899

Please sign in to comment.