fix: Ensure ServiceMonitor.spec.endpoints[0].port is a string

[connyay]

Failing to pass kubeconform checks internally

Description of the change

forces port to be a string.

before this change kubeconform failed with the following error:

stdin - ServiceMonitor backstage is invalid: problem validating schema. Check JSON formatting: jsonschema: '/spec/endpoints/0/port' does not validate with https://artifactory.ci.corp.tanium.com/artifactory/github/datreeio/CRDs-catalog/raw/main/monitoring.coreos.com/servicemonitor_v1.json#/properties/spec/properties/endpoints/items/properties/port/type: expected string, but got number

Existing or Associated Issue(s)

Additional Information

https://github.com/yannh/kubeconform

Checklist

• Chart version bumped in Chart.yaml according to semver.
• Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
• JSON Schema generated.
• List tests pass for Chart using the Chart Testing tool and the ct lint command.

[connyay]

Relates to #228

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

[ChrisJBurns]

@connyay Cheers for the PR. Any chance you could add some tests for the ServiceMonitor? We must have missed them when adding it initially, this should help us avoid any issues going forward. Some examples can be found here

[connyay]

Yup yup. Will do.

More from our findings - if metrics.serviceMonitor.port is an integer it should really make it to a targetPort property on the service monitor.

Will work on some tests for this.

[cursedcoder]

same with ArgoCD:

Failed sync attempt to bcb3d89bbd5cd5dc05f675c263dbcfe841486b00: one or more objects failed to apply, reason: error when patching "/dev/shm/3414896706": ServiceMonitor.monitoring.coreos.com "backstage" is invalid: spec.endpoints[0].port: Invalid value: "integer": spec.endpoints[0].port in body must be of type string: "integer"

currently this means OTEL integration is broken for some users

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

[imbabamba]

bump

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

[imbabamba]

any news on fixing otel servicemonitor?

[ChrisJBurns]

I think we may have to take this on ourselves unless @connyay is able to provide an update?

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

[imbabamba]

bump