Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update node.js to v20 #220

Merged
merged 3 commits into from
Feb 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jobs:
- uses: actions/checkout@v4

# Beginning of yarn setup
- name: use node.js 18.x
- name: use node.js 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x
registry-url: https://registry.npmjs.org/ # Needed for auth
- name: cache all node_modules
id: cache-modules
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pull.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
- uses: actions/checkout@v4

# Beginning of yarn setup
- name: use node.js 18.x
- name: use node.js 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x
registry-url: https://registry.npmjs.org/ # Needed for auth
- name: cache all node_modules
id: cache-modules
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/techdocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ jobs:
repository: backstage/backstage
fetch-depth: 1

- name: Setup Node 18.x
- name: Setup Node 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x
registry-url: https://registry.npmjs.org/ # Needed for auth

- name: Setup Python 3.9
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/version-bump.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ jobs:
fetch-depth: 1

# Beginning of yarn setup
- name: use node.js 18.x
- name: use node.js 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x
registry-url: https://registry.npmjs.org/ # Needed for auth
- name: cache all node_modules
id: cache-modules
Expand Down
9 changes: 5 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
ARG ENVIRONMENT_CONFIG=heroku

# Stage 1 - Create yarn install skeleton layer
FROM node:18-bookworm-slim AS packages
FROM node:20-bookworm-slim AS packages
ARG ENVIRONMENT_CONFIG

WORKDIR /app
Expand All @@ -16,7 +16,7 @@ COPY packages packages
RUN find packages \! -name "package.json" -mindepth 2 -maxdepth 2 -print | xargs rm -rf

# Stage 2 - Install dependencies and build packages
FROM node:18-bookworm-slim AS build
FROM node:20-bookworm-slim AS build
ARG ENVIRONMENT_CONFIG

# Set Python interpreter for `node-gyp` to use
Expand Down Expand Up @@ -50,7 +50,7 @@ RUN mkdir packages/backend/dist/skeleton packages/backend/dist/bundle \
&& tar xzf packages/backend/dist/bundle.tar.gz -C packages/backend/dist/bundle

# Stage 3 - Build the actual backend image and install production dependencies
FROM node:18-bookworm-slim
FROM node:20-bookworm-slim
ARG ENVIRONMENT_CONFIG

# Set Python interpreter for `node-gyp` to use
Expand Down Expand Up @@ -105,7 +105,8 @@ ENV PORT 7007
# This switches many Node.js dependencies to production mode.
ENV NODE_ENV production
# Sets the max memory size of V8's old memory section
ENV NODE_OPTIONS "--max-old-space-size=1000"
# Also disables node snapshot for Node 20 to work with the Scaffolder
ENV NODE_OPTIONS "--max-old-space-size=1000 --no-node-snapshot"

# Default is 'heroku', for local testing pass in 'local'
ENV ENVIRONMENT_CONFIG=${ENVIRONMENT_CONFIG}
Expand Down
2 changes: 1 addition & 1 deletion packages/app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"@playwright/test": "^1.32.3",
"@testing-library/jest-dom": "^6.0.0",
"@testing-library/react": "^14.0.0",
"@types/node": "^12.0.0",
"@types/node": "^20.0.0",
"@types/react-dom": "*",
"@types/uuid": "^9.0.0",
"uuid": "^9.0.1"
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -12659,7 +12659,7 @@ __metadata:
languageName: node
linkType: hard

"@types/node@npm:*, @types/node@npm:>=12.12.47, @types/node@npm:>=13.7.0, @types/node@npm:^20.1.1, @types/node@npm:^20.10.5":
"@types/node@npm:*, @types/node@npm:>=12.12.47, @types/node@npm:>=13.7.0, @types/node@npm:^20.0.0, @types/node@npm:^20.1.1, @types/node@npm:^20.10.5":
version: 20.11.19
resolution: "@types/node@npm:20.11.19"
dependencies:
Expand All @@ -12668,7 +12668,7 @@ __metadata:
languageName: node
linkType: hard

"@types/node@npm:^12.0.0, @types/node@npm:^12.7.1":
"@types/node@npm:^12.7.1":
version: 12.20.55
resolution: "@types/node@npm:12.20.55"
checksum: e4f86785f4092706e0d3b0edff8dca5a13b45627e4b36700acd8dfe6ad53db71928c8dee914d4276c7fd3b6ccd829aa919811c9eb708a2c8e4c6eb3701178c37
Expand Down Expand Up @@ -14093,7 +14093,7 @@ __metadata:
"@playwright/test": ^1.32.3
"@testing-library/jest-dom": ^6.0.0
"@testing-library/react": ^14.0.0
"@types/node": ^12.0.0
"@types/node": ^20.0.0
"@types/react-dom": "*"
"@types/uuid": ^9.0.0
react: ^18.2.0
Expand Down
Loading