-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate tensorflow 1.0 or higher #23
base: master
Are you sure you want to change the base?
Conversation
and also, migrate tf version 1.0 or above and python 3.5
@backstopmedia / @samjabrahams - please update this - or specify hard version with pip install requirements to older tensorflow. |
Thanks, BGPark. I was able to adjust much of the code to suit the new API but your code is making my life much easier. Hopefully, the authors will update their code. |
@michael-GitHub-0 Did all examples work for you with this patch? |
@danijar I am sorry, I haven't tried all of the code by BGPark. I only found this while working on chapter 5, and then I only pop over if I get stuck. I am new to GitHub. |
It would be really nice if all examples are fixed under tf 1.0 or higher. |
The book started out very well, but something changed beginning with chapter 5. The writing was less explanatory (more typos, too) and more difficult to work with. I have made a few GitHub posts and sometimes the authors respond, and sometimes they don't. I have moved on to another book, myself. |
Thank you For your work ! |
Migrate some examples to the new API (1.0 or later). I have confirmed that my modifications work with TF versions 1.0 and 1.1.
However, the remaining uncommitted examples (araxiv and CNNs examples) still have problems with the new API.
It is not perfect, but I hope it helps others.