fix(createtestfromscenario): switch from using Cypress fail event to …

…mocha runner fail event

it seems that cypress fail event could have only one listener and in case user has own or other
plugins use it cucumber json will be missing results for failed tests as this event is not emitted

re #459, re#454, re#417, re#348

lib/createTestFromScenario.js

@@ -103,12 +103,10 @@ const createTestFromScenarios = (
     window.testState = testState;
 
     const failHandler = (err) => {
-      Cypress.off("fail", failHandler);
       testState.onFail(err);
-      throw err;
     };
 
-    Cypress.on("fail", failHandler);
+    Cypress.mocha.getRunner().on("fail", failHandler);
   });
 
   allScenarios.forEach((section) => {

lib/testHelpers/setupTestFramework.js

@@ -10,6 +10,13 @@ window.Cypress = {
   on: jest.fn(),
   off: jest.fn(),
   log: jest.fn(),
+  mocha: {
+    getRunner: () => {
+      return {
+        on: jest.fn(),
+      };
+    },
+  },
   Promise: { each: (iterator, iteree) => iterator.map(iteree) },
 };