-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parse growth file task #14
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #14 +/- ##
==========================================
+ Coverage 0.00% 24.14% +24.14%
==========================================
Files 13 15 +2
Lines 293 352 +59
==========================================
+ Hits 0 85 +85
+ Misses 293 267 -26
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hi @jessicasyu, I completed the A few things I would like to mention:
Thank you so much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start! The structure of the repo has changed so you'll need to fix merge conflicts. In particular, revisit how the __init__.py
is handled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Isabelle-C This version is pretty far behind main at this point, I would merge main into this branch and fix any merge conflicts/linting errors (I think there are a couple mypy issues). It might make sense to have this PR just be for the parse growth file task, and put the parse params file task into a different PR.
@jessicasyu Sounds great! I merged main, fixed and mypy error, and deleted the parse param. Once this PR is finished, I will open a new one for the parse param. I was wondering in the |
Resolves #13