Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile has been updated #23

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

koustav-pal
Copy link

The previous Dockerfile images did not allow execution of post-processing scripts. Therefore, the dockerfile has been updated to allow the execution of screen.py, outliers.py and postprocessing.py.

Furthermore, python installation has been added with corresponding versioning.

@lfearnley
Copy link
Contributor

Hi @koustav-pal! We originally hadn't included the post-processing scripts in that Dockerfile in the hopes that it would reduce the image size when scaling up. Let me check what the image size differences are and I'll merge if they're not significantly different.

@lfearnley
Copy link
Contributor

Oh, also, two minor things:

3a816db changes the repo from the superSTR repo to your fork of it as well as updating the path; please correct this.

Could you please split your changes to the dockerfile and your updates to screen.py into two separate pulls?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants