Fix erroneous DID for keys

bahner · Apr 23, 2024 · 27f9a3c · 27f9a3c
1 parent 1f8ffeb
commit 27f9a3c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 12 deletions.
diff --git a/did/doc/document.go b/did/doc/document.go
@@ -113,11 +113,3 @@ func compareSlices(a []string, b []string) bool {
 
 	return slices.Compare(a, b) == 0
 }
-
-// func (d *Document) Path() path.Path {
-// 	return d.immutablePath
-// }
-
-// func (d *Document) DID() did.DID {
-// 	return d.did
-// }
diff --git a/key/encryption.go b/key/encryption.go
@@ -31,8 +31,8 @@ func NewEncryptionKey(d did.DID) (EncryptionKey, error) {
 		return EncryptionKey{}, fmt.Errorf("NewEncryptionKey: %w", err)
 	}
 
-	// We just mangle the base DID as this is not a pointer to a DID.
-	d.Fragment = name
+	// Create a unique identifier for the key
+	d = did.New(d.IPNSName(), name)
 
 	// Generate a random private key
 	var privKey [curve25519.ScalarSize]byte

diff --git a/key/signing.go b/key/signing.go
@@ -41,8 +41,9 @@ func NewSigningKey(d did.DID) (SigningKey, error) {
 	if err != nil {
 		return SigningKey{}, fmt.Errorf("NewSigningKey: %w", err)
 	}
-	// We just mangle the base DID as this is not a pointer to a DID.
-	d.Fragment = name
+
+	// Create a unique identifier for the key
+	d = did.New(d.IPNSName(), name)
 
 	publicKey, privKey, err := ed25519.GenerateKey(rand.Reader)
 	if err != nil {