Add console string quoting. #705
Conversation
|
Is there some reason this pull request has not been acted on? Is the ArduinoBuild / Build ESP32 examples build failure check holding it up? |
that can be ignored as it is trying to use the latest arduino-esp32 that isn't supported on master (and won't be anytime soon). |
|
So, what is holding up the pull request? I would like to be synced and up-to-date, but I need this update for my PocketBeagle command station, so the version of OpenMRN on my BeagleBone build box is being held back waiting for this PR... |
|
Is there something I need to do to get this pull request approved? |
src/console/Console.cxxtest
Outdated
| @@ -22,7 +22,7 @@ TEST(ConsoleTest, testHelp) | |||
| " has an effect on socket based logins sessions\n" | |||
| "> ", 154)); | |||
|
|
|||
| EXPECT_EQ(::write(s, "?\n", 3), 3); | |||
| EXPECT_EQ(::write(s, "?\n", 5), 5); | |||
There was a problem hiding this comment.
This change does not seem right. There are only three characters in that string (question mark, newline, zero). We should not write 5 bytes here.
| EXPECT_EQ(::write(s, "echo '\"Oh no, no, no\", said the man'\n", 37), 37); | ||
| usleep(1000); | ||
| EXPECT_EQ(::read(s, buf, 1024), 32); | ||
| EXPECT_TRUE(!strncmp(buf, "\"Oh no, no, no\", said the man\n> ", 32)); |
There was a problem hiding this comment.
consider adding another test case with mismatched quote to exercise the error path as well. This will be helpful to keep test coverage high.
|
I am not sure why this pull request is still lingering. I can't tell if there are still outstanding problems. |
@RobertPHeller I agree that we have not been very attentive to this. I will try and take another look through the code and existing comments. I also want to make sure all the tests pass. I'll let you know what I find. |
This is a new attempt to get this into the root fork. I need this patch for my command station code. This is a feature enhancement to allow consoles to allow quoting command line parameters, specificly to allow command line parameters with spaces and other word break characters.