Add swallow/window icon compatibility #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swallowed the old icon (usually from the terminal emulator) is preserved. This is noticeable if you, say run `mpv` from a terminal emulator which is a common use case.
|
Oh right, I forget that dwm-flexipatch is using the old swallow patch. Can you correct the indentation to use tabs instead of spaces? |
|
Done, I apologize, using spaces is a bad habit of mine! |
|
Thanks for the patch. |
UtkarshVerma
pushed a commit
to UtkarshVerma/dwm
that referenced
this pull request
Feb 19, 2023
* Add swallow/window icon compatibility. Without this, after a client is swallowed the old icon (usually from the terminal emulator) is preserved. This is noticeable if you, say run `mpv` from a terminal emulator which is a common use case. --------- Co-authored-by: speedie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add swallow/window icon compatibility. Without this, after a client is swallowed the old icon (usually from the terminal emulator) is preserved. This is noticeable if you, say run
mpvfrom a terminal emulator which is a common use case for the swallow patch.This pull request fixes this by simply calling
updateiconinswallowandunswallow, I have tested this and it works perfectly (unlike my last PR). I actually thought about just callingupdateiconinupdatetitlewhich would solve all of these issues but I'm not aware of any more issues so this will do I think.