Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PERTAGSEL_PATCH to fix issue #387 #389

Closed
wants to merge 3 commits into from
Closed

Add PERTAGSEL_PATCH to fix issue #387 #389

wants to merge 3 commits into from

Conversation

ysl2
Copy link
Contributor

@ysl2 ysl2 commented Nov 6, 2023

@ysl2
Copy link
Contributor Author

ysl2 commented Nov 6, 2023

You can test this pull request by following these steps:

  1. Open FAKEFULLSCREEN_PATCH, PERTAG_PATCH, STICKY_PATCH, SHIFTVIEW_CLIENTS_PATCH and the new PERTAGSEL_PATCH.
  2. Open a video from youtube, set it to sticky and float, and fullscreen. Then it will be a small window with video playing.
  3. Test 1: Switch to another tag, open a terminal, and use focusstack to switch clients from sticy to non-sticky.
  4. Test 2: In another tag. focus the sticky window, then use shiftviewclients to swith tags.

You can see the difference between this pull request and orginal code in step 3 and step 4.

@ysl2
Copy link
Contributor Author

ysl2 commented Nov 7, 2023

We shouldn't use sel in pertag, as mentioned in #387

@ysl2 ysl2 closed this Nov 7, 2023
@ysl2 ysl2 deleted the public-pertagsel branch November 16, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ysl2