refactor #1
Open
refactor #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, this is not merely a pull request but an almost complete rewrite that adds an architecture and tests to the script. I am not the maintainer but I like it, some comments follow. |
| @@ -0,0 +1,67 @@ | |||
| import abc | |||
| import json | |||
There was a problem hiding this comment.
The name of the module should probably be with two t letters, eg Formatter
|
I guess this needs a bit more care, I will make in weeks, and see if it is worth merging. |
|
I think this could be merged even before that as it makes the code much better. But its not up to me to decide that. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored version of the scripts, with the same UI.