Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding missing parameters to sdk.pools.buildExitExactBPTIn method; #534

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Adding missing parameters to sdk.pools.buildExitExactBPTIn method; #534

merged 3 commits into from
Sep 12, 2023

Conversation

lgahdl
Copy link
Contributor

@lgahdl lgahdl commented Sep 11, 2023

No description provided.

brunoguerios
brunoguerios approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@brunoguerios brunoguerios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why tests are failing, but the implementation seems pretty straightforward and LGTM 👍

@lgahdl lgahdl merged commit 812b02e into develop Sep 12, 2023
3 checks passed
@johngrantuk johngrantuk mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoguerios brunoguerios brunoguerios approved these changes

@johngrantuk johngrantuk Awaiting requested review from johngrantuk

@gmbronco gmbronco Awaiting requested review from gmbronco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgahdl @brunoguerios