Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add ethers v5 to deps instead of dev deps. #574

Merged
merged 2 commits into from
May 14, 2024
Merged

chore: Add ethers v5 to deps instead of dev deps. #574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3f07ec
chore: Add ethers v5 to deps instead of dev deps.
johngrantuk May 7, 2024
af7fd11
test: Skip goerli tests.
johngrantuk May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion balancer-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@
"eslint": "^7.9.0",
"eslint-plugin-mocha-no-only": "^1.1.1",
"eslint-plugin-prettier": "^3.1.4",
"ethers": "^5.0.0",
"fishery": "^2.2.2",
"hardhat": "^2.9.3",
"mocha": "^8.2.1",
Expand Down Expand Up @@ -99,6 +98,7 @@
"@ethersproject/contracts": "^5.4.0",
"@ethersproject/providers": "^5.4.5",
"axios": "^0.24.0",
"ethers": "^5",
"graphql": "^15.6.1",
"graphql-request": "^3.5.0",
"json-to-graphql-query": "^2.2.4",
Expand Down
2 changes: 1 addition & 1 deletion balancer-js/src/modules/exits/exits.module.integration.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const poolAddresses = Object.values(ADDRESSES[network]).map(
);
const addresses = ADDRESSES[network];

describe('generalised exit execution', async function () {
describe.skip('generalised exit execution', async function () {
this.timeout(120000); // Sets timeout for all tests within this scope to 2 minutes

/*
Expand Down
4 changes: 2 additions & 2 deletions balancer-js/src/modules/liquidity-managment/migrations.integrations.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ const migrations = (network: 1 | 137) => {
};

const remoteRpcUrls = {
[Network.MAINNET]: 'https://rpc.ankr.com/eth',
[Network.POLYGON]: 'https://rpc.ankr.com/polygon',
[Network.MAINNET]: process.env.ALCHEMY_URL,
[Network.POLYGON]: process.env.ALCHEMY_URL_POLYGON,
};

const blockNumbers = {
Expand Down
2 changes: 1 addition & 1 deletion balancer-js/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3482,7 +3482,7 @@ ethereumjs-util@^7.1.4:
ethereum-cryptography "^0.1.3"
rlp "^2.2.4"

ethers@^5.0.0:
ethers@^5:
version "5.7.2"
resolved "https://registry.yarnpkg.com/ethers/-/ethers-5.7.2.tgz#3a7deeabbb8c030d4126b24f84e525466145872e"
integrity sha512-wswUsmWo1aOK8rR7DIKiWSw9DbLWe6x98Jrn8wcTflTVvaXhAMaB5zGAXy0GYQEQp9iO1iSHWVyARQm11zUtyg==
Expand Down
Loading