Seems to be working on socket.io-client v4.7.5 #132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates PR-131 whilst adding another change that I ran into when testing with [email protected]
Tried to get the tests to pass but it seems there is an issue, atleast on my system, with phantomjs. So I worked around that and ran into another test issue where it fails on queueing -> requests -> after reconnecting socket
I tried to bump to the latest Sails version in package.json (not included in PR) but this seems to give the same issue as above.
Tested this out on with a
sails new application
and the client reconnects to the server when it stop/starts so it seems to be working fine. I am assuming that this test error has something to do with server side and within the test code or app setup within. Not sure.