Fix error in API docs for /url write method #179
Conversation
|
A repository maintainer needs to approve this workflow run. https://github.com/balena-io-experimental/browser/actions/runs/11427063220 Maintainers, please review all commits and react with 👍 to approve or 👎 to reject. Things to look for: GitHub Actions Security Cheat Sheet |
|
Hey there @lorenzowritescode - thanks for the contribution. The github actions flow failed because we need a change type in your commit message, like this: fc99cc5 There's some relevant guidance here: https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/changing-a-commit-message |
Change-type: minor After having issues with this API, I checked the source code and realised the /url path accepts POST, not PUT, in order to change url.
lorenzowritescode
force-pushed
the
patch-1
branch
from
48b9c81
to
ac0a36e
Compare
|
A repository maintainer needs to approve this workflow run. https://github.com/balena-io-experimental/browser/actions/runs/11666690561 Maintainers, please review all commits and react with 👍 to approve or 👎 to reject. Things to look for: GitHub Actions Security Cheat Sheet |
|
hey @phil-d-wilson can you re-run the CI workflow? |
|
@balena-ci retest |
|
A repository maintainer needs to approve this workflow run. https://github.com/balena-io-experimental/browser/actions/runs/11666690561 Maintainers, please review all commits and react with 👍 to approve or 👎 to reject. Things to look for: GitHub Actions Security Cheat Sheet |
|
Bad news @lorenzowritescode - you're close, but the change type has to be the last line of your commit message, with an empty line between the two |
Change-type: minor
After having issues with this API, I checked the source code and realised the /url path accepts POST, not PUT, in order to change url.