Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for They said so api token #81

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lmatter
Copy link
Contributor

@lmatter lmatter commented Dec 22, 2023

You now need an API token to get quote of the day.

@klutchell
Copy link
Contributor

Hey @lmatter, thanks for the contribution! Would you mind deleting the last two commits and make sure that at least one of your commits has a Change-type: major in the footer of the commit message? You can see some examples here.

@alanb128 would you be able to help test this functionality?

@alanb128
Copy link

I will try this out soon!

@lmatter lmatter force-pushed the they-said-so-api-token branch from eda32fe to e356324 Compare January 20, 2024 21:51
@lmatter
Copy link
Contributor Author

lmatter commented Jan 20, 2024

@klutchell This is the first time I messed with a PR like this; hopefully I did it correctly.

@alanb128
Copy link

Hey @lmatter I tested this and it works great, thanks!

Can you please update the README to reflect that setting the QUOTE_API_TOKEN is required, and then rebase your changes?

@lmatter
Copy link
Contributor Author

lmatter commented Jan 24, 2024

@alanb128 I changed the variable name for consistency with QOD_CATEGORY.

@klutchell
Copy link
Contributor

@lmatter would you mind squashing these two commits into one, and instead of merging with master perform a rebase on master?

Thanks again for the contribution, sorry to make you jump through so many hoops!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants