Project board fixes #96
Conversation
For now development should be done by pushing the code to a device on your local network, then starting the UI with the following command on your local system: HOSTNAME=balena.local yarn workspace ui dev The UI will then start locally with hot reload but draw on the running device on your network for the backend, allowing functionality like env setting.
HOSTNAME var used to override the backend URL is not changed to BACKEND_HOSTNAME because the HOSTNAME var was clashing with variables already on the device.
|
@nucleardreamer I have run out of days this week to finish this off but will pick it up again next week. A lot of ticks in the box already though. If you want you can start looking over the changes so far and I will continue next week in a new PR. |
This addition will only apply with the next Quasar release where there is an upstream fix for setting width of new windows
|
@nucleardreamer this should do it for now. Looking to merge this one. Not sure how to go about the review, maybe just have a scan over for anything obviously problematic, or anything that doesn't build or display properly. Will do a proper bug discovery the dog food way. Once it's merged Weblate will update itself and hopefully we will get the string translations contributed for the new and changed items. |
|
I now have time to review this, so I figure I will run it on a couple devices and make sure there isn't anything outstanding? @Maggie0002 |
maggie44
force-pushed
the
dev-updates
branch
from
287c234 to
01a85a8
Compare
I think that make sense. After this PR the next one will make things easier, because the next one will build all the apps too and will be available as assets in the PR. For now, there is the normal interface as usual, and if you go to |
maggie44
force-pushed
the
dev-updates
branch
from
bba4f5c to
3db6a87
Compare
maggie44
force-pushed
the
dev-updates
branch
from
3db6a87 to
7188d4e
Compare
|
Alright! I didn't run into any visible problems myself with this whole PR. I think its fine to roll without linking the PWA for now like you mentioned. This is fantastic!! |
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[X] Bug fix
[X] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Various fixes from the project board.
Which issue (if any) does this pull request address?
Closes: #79
Closes: #69
Is there anything you'd like reviewers to focus on?