add blind wait for flasher image when we can't detect state #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-type: patch Signed-off-by: Ryan Cooke <[email protected]>
| } | ||
| console.log('Internally flashed - powering off DUT'); | ||
| } else { | ||
| console.log(`Blindly waiting for DUT to interally flash - waiting for a period of ${BLIND_WAIT}... and hoping`) |
There was a problem hiding this comment.
Suggested change
| console.log(`Blindly waiting for DUT to interally flash - waiting for a period of ${BLIND_WAIT}... and hoping`) | |
| console.log(`There is no way to know if DUT has been flashed. Hence, waiting for DUT to complete flashing process internally for a period of ${BLIND_WAIT / 1000} seconds`) |
More positive console log message with a little more information and hope. Also, spelling fix
| if(BLIND_WAIT === false){ | ||
| while (dutOn) { | ||
| await delay(1000 * 10); // 10 seconds between checks | ||
| console.log(`waiting for DUT to be off`); |
There was a problem hiding this comment.
Suggested change
| console.log(`waiting for DUT to be off`); | |
| console.log(`Checking if DUT has turned off by now`); |
| // occasionally the DUT might appear to be powered down, but it isn't - we want to confirm that the DUT has stayed off for an interval of time | ||
| if (!dutOn) { | ||
| let offCount = 0; | ||
| console.log(`detected DUT has powered off - confirming...`); |
There was a problem hiding this comment.
Suggested change
| console.log(`detected DUT has powered off - confirming...`); | |
| console.log(`DUT power off detected: confirming ...`); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There exist some cases where we:
This PR adds a workaround, using the
FLASHER_IMAGE_WAITenv var, you can specify in ms a period to wait for the flasher image to flash the DUT internal storage, and then hope it's done.Change-type: patch