Add support for non-null ReferencedField optimization using model info #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Page-
force-pushed
the
model-based-optimizations
branch
from
802dd63
to
50dced9
Compare
|
@balena-ci retest |
Page-
force-pushed
the
model-based-optimizations
branch
2 times, most recently
from
305f95c
to
8c28cf9
Compare
Page-
force-pushed
the
model-based-optimizations
branch
2 times, most recently
from
79e5a63
to
5503416
Compare
Page-
commented
Jan 1, 2021
| @@ -215,6 +223,12 @@ SELECT NOT EXISTS ( | |||
| test.rule( | |||
| 'It is necessary that each plane that at least 3 pilots can fly, has a name', | |||
| `\ | |||
| SELECT 1 AS "result";`, | |||
There was a problem hiding this comment.
This is what it looks like when you write a rule that cannot be broken :P
Page-
commented
Jan 1, 2021
Comment on lines
+29
to
+30
| Term: nickname | ||
| Concept Type: Short Text (Type) |
There was a problem hiding this comment.
I needed a nullable term to actually be able to test we generated sensible rules as opposed to having them all optimized away to nothing because they couldn't be broken :|
Page-
force-pushed
the
model-based-optimizations
branch
3 times, most recently
from
6a74c34
to
c290a56
Compare
Page-
changed the title
Page-
force-pushed
the
model-based-optimizations
branch
from
c290a56
to
75c6d33
Compare
|
@balena-ci retest |
Page-
force-pushed
the
model-based-optimizations
branch
from
75c6d33
to
d61d299
Compare
We automatically use the model info to optimize rules/check constraints when compiling the schema. Change-type: minor
Page-
force-pushed
the
model-based-optimizations
branch
from
d61d299
to
37f50ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We automatically use the model info to optimize rules/check constraints
when compiling the schema.
Change-type: minor