Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move dataTypeGen to sbvrTypes and use it from there #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Move dataTypeGen to sbvrTypes and use it from there #2

wants to merge 2 commits into from

Conversation

izavits
Copy link
Contributor

@izavits izavits commented Dec 15, 2016

Move the dataTypeGen function to sbvrTypes as commented here: balena-io-modules/lf-to-abstract-sql#3 (comment)

Depends on balena-io-modules/sbvr-types#2

@resin-jenkins
Copy link

Can one of the admins verify this patch?

@Page-
Copy link
Contributor

Page- commented Dec 17, 2016

add to whitelist

Page-
Page- requested changes Dec 17, 2016
View reviewed changes
Copy link
Contributor

@Page- Page- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a package.json bump for sbvr-types once the change to that module is published

@izavits izavits force-pushed the move-dataTypeGen-to-sbvrTypes branch from 8db90ba to 176d28d Compare December 19, 2016 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Page- Page- Page- requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Page- Page-

@izavits izavits

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@izavits @resin-jenkins @Page-