-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow most printable ASCII chars for object label key (b-c) #13
base: master
Are you sure you want to change the base?
Conversation
We need to make sure the Supervisor never applies labels to containers/images because I think Docker will error. Also, please do not merge before the rest of product is prepared to handle this change. |
I created a PR on the Supervisor to accept a Target State with the expanded character set. I'll verify it does not apply a label itself. |
What preparation is required for balena-builder? balena-cli seems to work OK with the updated character set. IIRC I can |
I mean please do not merge this PR before the Supervisor one is merged and deployed. Also, it’s typically better to introduce changes to the builder first and then the CLI. |
Change-type: patch Signed-off-by: Ken Bannister <[email protected]>
ad2796c
to
e3ac16f
Compare
Change-type: patch Signed-off-by: Ken Bannister <[email protected]>
Change-type: patch Ref: balena-io-modules#13
Ensure all dependents of this package work before merging this PR!
Extends acceptable label characters to printable ASCII characters except space, single/double quotes and backtick. Updates minimal acceptable version of @types/dockerode to ensure build succeeds.
As of 2023-03-22 this PR still is blocked on an overall system solution between clients and server. This PR is useful; however older clients likely will fail in some way if they receive a service containing the extra characters.
Fixes #12