-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dotEtch generation and streaming methods #277
base: master
Are you sure you want to change the base?
Conversation
This is the same as #257 but with the fix (I deleted the branch for the other PR by mistake) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great stuff. Some general thoughts:
- I think a versioning scheme is worth devising early, for both when requesting etchfiles and when applying them. A simple major/minor should be fine, and clients/servers must reject majors larger than they know about and should make reasonable effort to work with older ones. This is only pertinent to this PR because you will likely need to inject the version somewhere in the stream.
- Can you please explain (once more :) why the supervisor needs special handling?
- Does the .etch format support (or how hard can it be made to support) the base image and injectables being optional? So you can have injectables without a base image, or a base image without injectables (far less useful). Similarly, can the base image be a manifest instead that enables everything etcher currently supports? Eg. from URL.
- console.log is fine for the first versions, but we should ultimately use a logger function/object/stream that is passed as an argument to the entrypoint so we can integrate logging with whatever clients use.
All very valid points :
|
I've added the manifest with a version 1.0 (1), it will be trivial to extend it to handle "url" for any asset in the stream (3) |
5c50d19
to
5c3389f
Compare
bd95b71
to
eb7ad6b
Compare
66fc0cf
to
e52f1f8
Compare
6134353
to
8bda19a
Compare
[aethernet] This has attached https://jel.ly.fish/62ec39b3-f868-46cd-ad7c-3d375b83f8ac |
required for preloading change-type: minor
c257dbd
to
380e7c2
Compare
required for preloading
change-type: minor