Update @balena/lint to v8.2.7 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshbwlng
force-pushed
the
joshbwlng/balena-lint
branch
from
a86df8f to
0ca39ea
Compare
joshbwlng
commented
Jul 31, 2024
| @@ -17,7 +17,7 @@ export const fetchProcessing: TypeUtils.FetchProcessing<Types['Read']> = ( | |||
| ) => { | |||
| if (data != null) { | |||
| // We append the date of the epoch so that we can parse this as a valid date. | |||
| return new Date('Thu, 01 Jan 1970 ' + data).toISOString(); | |||
| return new Date(`Thu, 01 Jan 1970 ${data}`).toISOString(); | |||
There was a problem hiding this comment.
Changing this because of @typescript-eslint/restrict-plus-operands
flowzone-app
bot
force-pushed
the
master
branch
from
ecf2e5e to
4030ebb
Compare
joshbwlng
force-pushed
the
joshbwlng/balena-lint
branch
from
0ca39ea to
3975e8f
Compare
Page-
reviewed
Aug 2, 2024
src/index.ts
Outdated
| @@ -82,6 +82,6 @@ export default { | |||
| }; | |||
| SHA: SbvrType & { | |||
| validateSync: (value: string) => string; | |||
| compare: (str: string, hash: string) => Promise<boolean>; | |||
| compare: (str: string, hash: string) => Promise<boolean> | boolean; | |||
There was a problem hiding this comment.
This is a breaking change because doing
sbvrTypes.SHA.compare(...).then(...)
would start to throw. In practice in most cases it'll probably be fine, eg await ... or .then(() => sbvrTypes.SHA.compare(...)) but it's not guaranteed
There was a problem hiding this comment.
Ok, I've reverted that change. So we'll still have 1 lint warning, but I'd rather that than a breaking change in this PR.
joshbwlng
force-pushed
the
joshbwlng/balena-lint
branch
from
3975e8f to
c6b6713
Compare
Change-type: patch
joshbwlng
force-pushed
the
joshbwlng/balena-lint
branch
from
c6b6713 to
630ca7d
Compare
thgreasi
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: patch
This updates balena lint and resolves most linting errors/warnings.