Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os configure: Locate the boot partition w/o using the device-type.json's partition field #2901

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

thgreasi
Copy link
Member

@thgreasi thgreasi commented Dec 18, 2024

On top of #2899, so let's get that in first for better debugging in case of an issue.

Update balena-device-init from 8.0.0 to 8.1.0

Depends-on: balena-io-modules/balena-device-init#47
Change-type: patch

@thgreasi thgreasi force-pushed the balena-device-init-v-8-1-0 branch 7 times, most recently from bd042dc to b64723f Compare December 19, 2024 22:27
@thgreasi thgreasi force-pushed the balena-device-init-v-8-1-0 branch from b64723f to 245a966 Compare December 20, 2024 17:13
src/utils/helpers.ts Outdated Show resolved Hide resolved
@thgreasi thgreasi force-pushed the balena-device-init-v-8-1-0 branch 4 times, most recently from c36c530 to 6281bb1 Compare December 24, 2024 19:12
@kb2ma kb2ma self-requested a review December 26, 2024 16:12
Copy link
Contributor

@kb2ma kb2ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests! Not approving only due to package version on balena-device-init.

@thgreasi thgreasi force-pushed the balena-device-init-v-8-1-0 branch 2 times, most recently from 9f2426b to 7a1c63e Compare December 30, 2024 14:00
@thgreasi thgreasi marked this pull request as ready for review December 30, 2024 15:45
@thgreasi thgreasi marked this pull request as draft December 30, 2024 16:19
@thgreasi thgreasi force-pushed the balena-device-init-v-8-1-0 branch 2 times, most recently from 6870ceb to e16dac5 Compare December 30, 2024 17:20
…age over the device-type.json contents

Update balena-device-init from 8.0.0 to 8.1.0

Change-type: minor
@thgreasi thgreasi force-pushed the balena-device-init-v-8-1-0 branch from e16dac5 to dbe177e Compare December 31, 2024 17:48
@kb2ma
Copy link
Contributor

kb2ma commented Dec 31, 2024

Testing

Testing jetson-xavier device type on staging.

v6.1.25

  • OK, Download
  • OK, device-type.json boot partition 43
  • OK, Configure, including WiFi

v6.1.26

  • OK, can't download, as expected
  • OK, device-type.json boot partition 37
  • OK, Configure, including WiFi

v3.1.3+rev1

  • OK, Download
  • OK, device-type.json boot partition 37
  • OK, Configure with CLI PR and configure with CLI v20.0.0 -- both with WiFi

RPi 4, netio-logger-pi4 fleet on balena-cloud

  • OK, Download
  • OK, device-type.json boot partition 1
  • OK, Configure with CLI PR

@kb2ma
Copy link
Contributor

kb2ma commented Dec 31, 2024

Retested configure of v6.1.26 with commit dbe177e, OK.

@kb2ma kb2ma marked this pull request as ready for review December 31, 2024 18:39
@kb2ma kb2ma merged commit f0ede6f into master Dec 31, 2024
60 checks passed
@kb2ma kb2ma deleted the balena-device-init-v-8-1-0 branch December 31, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants