Fix get_with_service_details typings #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otaviojacobi
requested review from
thgreasi,
myarmolinsky,
gantonayde and
pranasziaukas
otaviojacobi
commented
Dec 15, 2023
| @@ -157,6 +158,10 @@ class TypeApplication(TypedDict): | |||
| can_use__application_as_host: ReverseNavigationResource[ApplicationHostedOnApplication] | |||
|
|
|||
|
|
|||
| class TypeApplicationWithDeviceServiceDetails(TypeApplication): | |||
| owns__device: List["TypeDeviceWithServices"] # type: ignore | |||
There was a problem hiding this comment.
FWIW this is necessary as by default Python type hints won't allow overriding properties on TypedDicts
otaviojacobi
force-pushed
the
improves-service-running-types
branch
2 times, most recently
from
fe4ea4b to
2146970
Compare
otaviojacobi
force-pushed
the
improves-service-running-types
branch
3 times, most recently
from
73a6529 to
ac8c589
Compare
otaviojacobi
changed the title
otaviojacobi
force-pushed
the
improves-service-running-types
branch
from
ac8c589 to
b8f97b2
Compare
Change-type: patch
otaviojacobi
force-pushed
the
improves-service-running-types
branch
from
b8f97b2 to
9077f9d
Compare
fisehara
approved these changes
Dec 18, 2023
fisehara
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: patch