do not operate on empty or ambiguous device and release UUIDs #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otaviojacobi
force-pushed
the
avoid-deletion-with-incomplete-ids
branch
3 times, most recently
from
3130e48 to
a000a36
Compare
otaviojacobi
force-pushed
the
avoid-deletion-with-incomplete-ids
branch
3 times, most recently
from
856b331 to
e82b65e
Compare
thgreasi
reviewed
Oct 15, 2024
thgreasi
reviewed
Oct 15, 2024
|
|
|
Oh and |
otaviojacobi
force-pushed
the
avoid-deletion-with-incomplete-ids
branch
2 times, most recently
from
df16da5 to
c8df914
Compare
Change-type: patch
otaviojacobi
force-pushed
the
avoid-deletion-with-incomplete-ids
branch
from
c8df914 to
0766753
Compare
otaviojacobi
changed the title
thgreasi
reviewed
Oct 15, 2024
balena/models/release.py
Outdated
| @@ -57,6 +57,9 @@ def get( | |||
| if commit_or_id_or_raw_version is None: | |||
| raise exceptions.ReleaseNotFound(commit_or_id_or_raw_version) | |||
|
|
|||
| if commit_or_id_or_raw_version == '': | |||
| raise exceptions.InvalidParameter("UUID can not be empty", None) | |||
There was a problem hiding this comment.
Suggested change
| raise exceptions.InvalidParameter("UUID can not be empty", None) | |
| raise exceptions.InvalidParameter("commit_or_id_or_raw_version can not be empty", None) |
auto-merge was automatically disabled
October 15, 2024 17:03
Pull request was converted to draft
thgreasi
approved these changes
Oct 15, 2024
…g uuid Change-type: patch
otaviojacobi
force-pushed
the
avoid-deletion-with-incomplete-ids
branch
from
0766753 to
6d5d043
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: patch