Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch contracts links to markdown #1521

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

acostach
Copy link
Contributor

See: https://balena.zulipchat.com/#narrow/channel/350505-aspect.2Fgrowth/topic/Improving.20Jetson-flash.20documentation/near/493450821
Depends-on: balena-io/contracts#457
Change-type: patch


Contributor checklist
  • Includes tests
  • Includes typings
  • Includes updated documentation
  • Includes updated build output

@acostach acostach requested review from vipulgupta2048 and thgreasi and removed request for vipulgupta2048 January 14, 2025 16:33
@acostach acostach enabled auto-merge January 14, 2025 16:36
Copy link
Member

@vipulgupta2048 vipulgupta2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to run npm run lint-fix command or similar to resolve the error in CI

... because HTML links are no longer displayed in the dashboard
image download modal.

We also adapt the tests to these changes.

See internal thread: https://balena.zulipchat.com/#narrow/channel/350505-aspect.2Fgrowth/topic/Improving.20Jetson-flash.20documentation/near/493450821

Change-type: patch
Signed-off-by: Alexandru Costache <[email protected]>
@acostach acostach force-pushed the switch_contracts_links_to_markdown branch from 7ce38bc to 461dca2 Compare January 15, 2025 12:12
@acostach acostach merged commit f90f853 into master Jan 15, 2025
55 checks passed
@acostach acostach deleted the switch_contracts_links_to_markdown branch January 15, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants