Remove generic-amd64-fde device type #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@balena-ci rebase |
ghost
force-pushed
the
mtoman/remove_generic_amd64_fde
branch
from
19aba1c to
85da1b0
Compare
|
Hi @mtoman is this PR still valid? |
|
Hi @mtoman can we close this? |
FDE is a feature, it does not need a separate device type. Change-type: patch Signed-off-by: Michal Toman <[email protected]>
mtoman
force-pushed
the
mtoman/remove_generic_amd64_fde
branch
from
85da1b0 to
a9e475a
Compare
|
@floion Sorry, I've completely missed the previous ping. This is still valid, we do not need a separate device type for secure boot & disk encryption, it is an opt-in in the regular |
floion
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FDE will be a feature of the generic-amd64 rather than a separate DT.