Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ubuntu Noble #432

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

ruffsl
Copy link
Contributor

@ruffsl ruffsl commented Jul 15, 2024

This PR contains the following changes:

- Add support for Ubuntu Noble.

@ruffsl ruffsl marked this pull request as ready for review July 15, 2024 22:55
@klutchell
Copy link
Contributor

Thanks for the contribution @ruffsl ! Would you mind rebasing your branch on the latest from master?

Note that it needs to be a rebase, not an "update". After a rebase there should still only be one commit in your branch, and no merge commits.

@klutchell
Copy link
Contributor

Would you mind amending your commit message to include Change-type: patch in the footer?

@klutchell
Copy link
Contributor

Also I suggest looking at this commit as an example as there may be some dependencies files that need updating.

@ruffsl
Copy link
Contributor Author

ruffsl commented Aug 15, 2024

as there may be some dependencies files that need updating.

I'm not sure how to go about this. Is there a script of some sort to auto update those partial templates here?

@ruffsl ruffsl force-pushed the base-ubuntu-noble branch from 48c1dee to f98c780 Compare August 15, 2024 15:56
@flowzone-app flowzone-app bot enabled auto-merge August 15, 2024 16:00
@ruffsl
Copy link
Contributor Author

ruffsl commented Aug 19, 2024

ping @klutchell , PR rebased. Looks like CI is passing.

@klutchell
Copy link
Contributor

klutchell commented Aug 19, 2024

Great! I think the only thing that is missing now is the custom templates for ubuntu@noble.

A good starting point is to look at the existing templates for jammy, and create an identical corresponding template for noble.

./contracts/sw.os+hw.device-type/ubuntu@jammy+raspberrypi400-64/dependencies.tpl
./contracts/sw.os+hw.device-type/ubuntu@jammy+coral-dev/dependencies.tpl
./contracts/sw.os+hw.device-type/ubuntu@jammy+raspberry-pi2/dependencies.tpl
./contracts/sw.os+hw.device-type/ubuntu@jammy+raspberrypi3-64/dependencies.tpl
./contracts/sw.os+hw.device-type/ubuntu@jammy+raspberrypi0-2w-64/dependencies.tpl
./contracts/sw.os+hw.device-type/ubuntu@jammy+raspberrypi4-64/dependencies.tpl
./contracts/sw.os+hw.device-type/ubuntu@jammy+revpi-core-3/dependencies.tpl
./contracts/sw.os+hw.device-type/ubuntu@jammy+raspberrypi3/dependencies.tpl

Then a quick check to see if the names of any packages in those templates have changed between jammy and noble.

Once that is done I can open a draft PR on the base-images repo to point to your contracts branch and see if everything generates!

Change-type: patch
Signed-off-by: ruffsl <[email protected]>
auto-merge was automatically disabled August 19, 2024 15:47

Head branch was pushed to by a user without write access

@ruffsl ruffsl force-pushed the base-ubuntu-noble branch from f98c780 to 909a9e8 Compare August 19, 2024 15:47
@ruffsl
Copy link
Contributor Author

ruffsl commented Aug 19, 2024

Ok, I've duplicated the templates for ubuntu@noble. None of the package names seems to have changed, including:

@flowzone-app flowzone-app bot enabled auto-merge August 19, 2024 15:51
Copy link
Contributor

@klutchell klutchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Next we can wait for the auto-bump of this contracts change in the base-images repo and try a manual deployment of some of the new images for testing.

@flowzone-app flowzone-app bot merged commit 83fd140 into balena-io:master Aug 19, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants