-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Ubuntu Noble #432
Conversation
Thanks for the contribution @ruffsl ! Would you mind rebasing your branch on the latest from master? Note that it needs to be a rebase, not an "update". After a rebase there should still only be one commit in your branch, and no merge commits. |
24623c1
to
48c1dee
Compare
Would you mind amending your commit message to include |
Also I suggest looking at this commit as an example as there may be some dependencies files that need updating. |
I'm not sure how to go about this. Is there a script of some sort to auto update those partial templates here? |
48c1dee
to
f98c780
Compare
ping @klutchell , PR rebased. Looks like CI is passing. |
Great! I think the only thing that is missing now is the custom templates for ubuntu@noble. A good starting point is to look at the existing templates for jammy, and create an identical corresponding template for noble.
Then a quick check to see if the names of any packages in those templates have changed between jammy and noble. Once that is done I can open a draft PR on the base-images repo to point to your contracts branch and see if everything generates! |
Change-type: patch Signed-off-by: ruffsl <[email protected]>
Head branch was pushed to by a user without write access
f98c780
to
909a9e8
Compare
Ok, I've duplicated the templates for ubuntu@noble. None of the package names seems to have changed, including: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Next we can wait for the auto-bump of this contracts change in the base-images repo and try a manual deployment of some of the new images for testing.
This PR contains the following changes: